netdev - Re: [net-next v2 0/8][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-05

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190805204620.2e27c95b@cakuba.netronome.com>
Date:   Mon, 5 Aug 2019 20:46:20 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com
Subject: Re: [net-next v2 0/8][pull request] 40GbE Intel Wired LAN Driver
 Updates 2019-08-05

On Mon,  5 Aug 2019 11:54:51 -0700, Jeff Kirsher wrote:
> This series contains updates to i40e driver only.
> 
> Dmitrii adds missing statistic counters for VEB and VEB TC's.
> 
> Slawomir adds support for logging the "Disable Firmware LLDP" flag
> option and its current status.
> 
> Jake fixes an issue where VF's being notified of their link status
> before their queues are enabled which was causing issues.  So always
> report link status down when the VF queues are not enabled.  Also adds
> future proofing when statistics are added or removed by adding checks to
> ensure the data pointer for the strings lines up with the expected
> statistics count.
> 
> Czeslaw fixes the advertised mode reported in ethtool for FEC, where the
> "None BaseR RS" was always being displayed no matter what the mode it
> was in.  Also added logging information when the PF is entering or
> leaving "allmulti" (or promiscuous) mode.  Fixed up the logging logic
> for VF's when leaving multicast mode to not include unicast as well.

I can understand patch 2 may be useful for troubleshooting since FW
agent is involved. But I can't really say the same for patch 6 :S
If those entered allmutli/left allmutli messages were of value core
should print them instead..

But anyway, that's not a big deal, looks reasonable.