netdev - Re: [PATCH 12/17] skge: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190806104412.6e462c4b@hermes.lan>
Date:   Tue, 6 Aug 2019 10:44:12 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     netdev@...r.kernel.org, Mirko Lindner <mlindner@...vell.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 12/17] skge: no need to check return value of
 debugfs_create functions

On Tue,  6 Aug 2019 18:11:23 +0200
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Cc: Mirko Lindner <mlindner@...vell.com>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Stephen Hemminger <stephen@...workplumber.org>

Did not pull card out of dust bin to test it though