netdev - Re: [PATCH 1/3] net: dsa: ksz: Remove dead code and fix warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190806.115934.1807630426878001706.davem@davemloft.net>
Date:   Tue, 06 Aug 2019 11:59:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     marex@...x.de
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
        Tristram.Ha@...rochip.com, vivien.didelot@...il.com,
        woojung.huh@...rochip.com
Subject: Re: [PATCH 1/3] net: dsa: ksz: Remove dead code and fix warnings

From: Marek Vasut <marex@...x.de>
Date: Tue,  6 Aug 2019 15:06:07 +0200

> Remove ksz_port_cleanup(), which is unused. Add missing include
> "ksz_common.h", which fixes the following warning when built with
> make ... W=1
> 
> drivers/net/dsa/microchip/ksz_common.c:23:6: warning: no previous prototype for ‘...’ [-Wmissing-prototypes]
> 
> Note that the order of the headers cannot be swapped, as that would
> trigger missing forward declaration errors, which would indicate the
> way forward is to merge the two headers into one.
> 
> Signed-off-by: Marek Vasut <marex@...x.de>

Applied.