netdev - Re: [PATCH net-next] net: dsa: sja1105: remove set but not used variables 'tx_vid' and 'rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Aug 2019 10:15:54 -0400
From:   Vivien Didelot <vivien.didelot@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     davem@...emloft.net, olteanv@...il.com, andrew@...n.ch,
        f.fainelli@...il.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] net: dsa: sja1105: remove set but not used
 variables 'tx_vid' and 'rx_vid'

On Wed, 7 Aug 2019 21:08:56 +0800, YueHaibing <yuehaibing@...wei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/dsa/sja1105/sja1105_main.c: In function sja1105_fdb_dump:
> drivers/net/dsa/sja1105/sja1105_main.c:1226:14: warning:
>  variable tx_vid set but not used [-Wunused-but-set-variable]
> drivers/net/dsa/sja1105/sja1105_main.c:1226:6: warning:
>  variable rx_vid set but not used [-Wunused-but-set-variable]
> 
> They are not used since commit 6d7c7d948a2e ("net: dsa:
> sja1105: Fix broken learning with vlan_filtering disabled")
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Vivien Didelot <vivien.didelot@...il.com>