netdev - Re: [PATCH] zd1211rw: remove false assertion from zd_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 08 Aug 2019 11:05:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     oneukum@...e.com
Cc:     netdev@...r.kernel.org, dsd@...too.org, kune@...ne-taler.de,
        linux-wireless@...r.kernel.org, kvalo@...eaurora.org
Subject: Re: [PATCH] zd1211rw: remove false assertion from zd_mac_clear()

From: Oliver Neukum <oneukum@...e.com>
Date: Thu,  8 Aug 2019 11:32:03 +0200

> The function is called before the lock which is asserted was ever used.
> Just remove it.
> 
> Reported-by: syzbot+74c65761783d66a9c97c@...kaller.appspotmail.com
> Signed-off-by: Oliver Neukum <oneukum@...e.com>

Please CC: the appropriate driver maitainers and mailing list as this
is clearly specified in the MAINTAINERS file.

Thank you.

> ---
>  drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> index da7e63fca9f5..a9999d10ae81 100644
> --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> @@ -223,7 +223,6 @@ void zd_mac_clear(struct zd_mac *mac)
>  {
>  	flush_workqueue(zd_workqueue);
>  	zd_chip_clear(&mac->chip);
> -	lockdep_assert_held(&mac->lock);
>  	ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
>  }
>  
> -- 
> 2.16.4
>