netdev - Re: [PATCH 0/2 net,v4] flow_offload hardware priority fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190809.125751.1142334849531721357.davem@davemloft.net>
Date:   Fri, 09 Aug 2019 12:57:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pablo@...filter.org
Cc:     netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        marcelo.leitner@...il.com, jiri@...nulli.us, wenxu@...oud.cn,
        saeedm@...lanox.com, paulb@...lanox.com, gerlitz.or@...il.com,
        jakub.kicinski@...ronome.com
Subject: Re: [PATCH 0/2 net,v4] flow_offload hardware priority fixes

From: David Miller <davem@...emloft.net>
Date: Fri, 09 Aug 2019 12:37:41 -0700 (PDT)

> From: Pablo Neira Ayuso <pablo@...filter.org>
> Date: Tue,  6 Aug 2019 18:03:08 +0200
> 
>> This patchset contains two updates for the flow_offload users:
>> 
>> 1) Pass the major tc priority to drivers so they do not have to
>>    lshift it. This is a preparation patch for the fix coming in
>>    patch #2.
>> 
>> 2) Set the hardware priority from the netfilter basechain priority,
>>    some drivers break when using the existing hardware priority
>>    number that is set to zero.
> 
> Series applied.

Sorry, I had to revert:

[davem@...alhost net]$ make -s -j14
In file included from ./include/linux/list.h:9,
                 from ./include/linux/module.h:9,
                 from net/netfilter/nf_tables_offload.c:3:
net/netfilter/nf_tables_offload.c: In function ‘nft_chain_offload_priority’:
./include/linux/kernel.h:269:23: warning: overflow in conversion from ‘short int’ to ‘signed char’ changes value from ‘-32768’ to ‘0’ [-Woverflow]
  ({ signed type __x = (x); __x < 0 ? -__x : __x; }), other)
                       ^
./include/linux/kernel.h:256:16: note: in expansion of macro ‘__abs_choose_expr’
 #define abs(x) __abs_choose_expr(x, long long,    \
                ^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:257:3: note: in expansion of macro ‘__abs_choose_expr’
   __abs_choose_expr(x, long,    \
   ^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:258:3: note: in expansion of macro ‘__abs_choose_expr’
   __abs_choose_expr(x, int,    \
   ^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:259:3: note: in expansion of macro ‘__abs_choose_expr’
   __abs_choose_expr(x, short,    \
   ^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:260:3: note: in expansion of macro ‘__abs_choose_expr’
   __abs_choose_expr(x, char,    \
   ^~~~~~~~~~~~~~~~~
net/netfilter/nf_tables_offload.c:134:35: note: in expansion of macro ‘abs’
  return basechain->ops.priority + abs(SHRT_MIN);
                                   ^~~
./include/linux/kernel.h:263:31: warning: overflow in conversion from ‘short int’ to ‘signed char’ changes value from ‘-32768’ to ‘0’ [-Woverflow]
    (char)({ signed char __x = (x); __x<0?-__x:__x; }), \
                               ^
./include/linux/kernel.h:269:54: note: in definition of macro ‘__abs_choose_expr’
  ({ signed type __x = (x); __x < 0 ? -__x : __x; }), other)
                                                      ^~~~~
./include/linux/kernel.h:257:3: note: in expansion of macro ‘__abs_choose_expr’
   __abs_choose_expr(x, long,    \
   ^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:258:3: note: in expansion of macro ‘__abs_choose_expr’
   __abs_choose_expr(x, int,    \
   ^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:259:3: note: in expansion of macro ‘__abs_choose_expr’
   __abs_choose_expr(x, short,    \
   ^~~~~~~~~~~~~~~~~
./include/linux/kernel.h:260:3: note: in expansion of macro ‘__abs_choose_expr’
   __abs_choose_expr(x, char,    \
   ^~~~~~~~~~~~~~~~~
net/netfilter/nf_tables_offload.c:134:35: note: in expansion of macro ‘abs’
  return basechain->ops.priority + abs(SHRT_MIN);
                                   ^~~