netdev - Re: [net v2] ixgbe: fix possible deadlock in ixgbe_service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190809.131714.21657168204830538.davem@davemloft.net>
Date:   Fri, 09 Aug 2019 13:17:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     ap420073@...il.com, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, andrewx.bowers@...el.com
Subject: Re: [net v2] ixgbe: fix possible deadlock in ixgbe_service_task()

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu,  8 Aug 2019 09:37:56 -0700

> From: Taehee Yoo <ap420073@...il.com>
> 
> ixgbe_service_task() calls unregister_netdev() under rtnl_lock().
> But unregister_netdev() internally calls rtnl_lock().
> So deadlock would occur.
> 
> Fixes: 59dd45d550c5 ("ixgbe: firmware recovery mode")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
> v2: removed unnecessary curly brackets

Applied, thanks everyone.