netdev - Re: [PATCH v2 net-next] taprio: remove unused variable 'entry_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 09 Aug 2019 13:41:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        vinicius.gomes@...el.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] taprio: remove unused variable
 'entry_list_policy'

From: YueHaibing <yuehaibing@...wei.com>
Date: Fri, 9 Aug 2019 09:49:23 +0800

> net/sched/sch_taprio.c:680:32: warning:
>  entry_list_policy defined but not used [-Wunused-const-variable=]
> 
> One of the points of commit a3d43c0d56f1 ("taprio: Add support adding
> an admin schedule") is that it removes support (it now returns "not
> supported") for schedules using the TCA_TAPRIO_ATTR_SCHED_SINGLE_ENTRY
> attribute (which were never used), the parsing of those types of schedules
> was the only user of this policy. So removing this policy should be fine.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Suggested-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: respin commit log using Vinicius's explanation.

Applied.