netdev - Re: [PATCH 00/17] Networking driver debugfs cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190808.184237.1532563308186831482.davem@davemloft.net>
Date:   Thu, 08 Aug 2019 18:42:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gregkh@...uxfoundation.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 00/17] Networking driver debugfs cleanups

From: David Miller <davem@...emloft.net>
Date: Thu, 08 Aug 2019 18:37:56 -0700 (PDT)

> I applied this without patch #17 which you said you would respin in order
> to get rid of the now unused local variable.

Actually, there is a bunch of fallout still:

drivers/net/wimax/i2400m/debugfs.c: In function ‘i2400m_debugfs_add’:
drivers/net/wimax/i2400m/debugfs.c:192:17: warning: unused variable ‘dev’ [-Wunused-variable]
  struct device *dev = i2400m_dev(i2400m);
                 ^~~
drivers/net/wimax/i2400m/usb.c: In function ‘i2400mu_debugfs_add’:
drivers/net/wimax/i2400m/usb.c:375:17: warning: unused variable ‘fd’ [-Wunused-variable]
  struct dentry *fd;
                 ^~
drivers/net/wimax/i2400m/usb.c:373:17: warning: unused variable ‘dev’ [-Wunused-variable]
  struct device *dev = &i2400mu->usb_iface->dev;
                 ^~~
drivers/net/wimax/i2400m/usb.c:372:6: warning: unused variable ‘result’ [-Wunused-variable]
  int result;
      ^~~~~~
drivers/net/ethernet/intel/i40e/i40e_debugfs.c: In function ‘i40e_dbg_pf_init’:
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:1736:23: warning: unused variable ‘dev’ [-Wunused-variable]
  const struct device *dev = &pf->pdev->dev;
                       ^~~

This is with:

[davem@...alhost net-next]$ gcc --version
gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[davem@...alhost net-next]$ 

So I'm reverting.

Please respin the series with this stuff fixed, thanks Greg.