netdev - Regression in routing table cleanup when VRF support was fixed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAK0T-BLWTeDqX7-4KuYcUNNwg1vjiG9x70cUxiELzMkOEPufsw@mail.gmail.com>
Date:   Fri, 9 Aug 2019 15:01:52 -0700
From:   Craig Robson <craig@...tt.com>
To:     netdev@...r.kernel.org
Subject: Regression in routing table cleanup when VRF support was fixed.

This commit caused a regression for me when using policy routing.

5a56a0b3a45d net: Don't delete routes in different VRFs

The regression is that routes are no longer getting deleted when I delete IP
addresses when using non-default routing tables.

For example the following sequence used to delete the routing entry in table
100 when the ip was deleted, but after the above commit is does not delete the
routing table entry.

Setup
# ip link set dummy0 up
# ip addr add 10.10.10.10/24 dev dummy0
# ip addr add 192.168.10.10/24 dev dummy0
# ip route add dev dummy0 192.168.10.0/24 table 100 scope link src 192.168.10.10
# ip route show table 100
192.168.10.0/24 dev dummy0 scope link  src 192.168.10.10

Cleanup
# ip addr del 192.168.10.10/24 dev dummy0

Routing entry still exists and should not.
# ip route show table 100
192.168.10.0/24 dev dummy0 scope link  src 192.168.10.10

This was previously working (deleting the route) since at least 2.6.32.  I am
not using VRFs.  What needs fixed to get the old behavior?

Regards,
Craig Robson