netdev - Re: [PATCH v2] bonding: Add vlan tx offload to hw_enc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 08 Aug 2019 22:02:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net,
        jiri@...nulli.us, jay.vosburgh@...onical.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] bonding: Add vlan tx offload to hw_enc_features

From: YueHaibing <yuehaibing@...wei.com>
Date: Wed, 7 Aug 2019 10:19:59 +0800

> As commit 30d8177e8ac7 ("bonding: Always enable vlan tx offload")
> said, we should always enable bonding's vlan tx offload, pass the
> vlan packets to the slave devices with vlan tci, let them to handle
> vlan implementation.
> 
> Now if encapsulation protocols like VXLAN is used, skb->encapsulation
> may be set, then the packet is passed to vlan device which based on
> bonding device. However in netif_skb_features(), the check of
> hw_enc_features:
> 
> 	 if (skb->encapsulation)
>                  features &= dev->hw_enc_features;
> 
> clears NETIF_F_HW_VLAN_CTAG_TX/NETIF_F_HW_VLAN_STAG_TX. This results
> in same issue in commit 30d8177e8ac7 like this:
> 
> vlan_dev_hard_start_xmit
>   -->dev_queue_xmit
>     -->validate_xmit_skb
>       -->netif_skb_features //NETIF_F_HW_VLAN_CTAG_TX is cleared
>       -->validate_xmit_vlan
>         -->__vlan_hwaccel_push_inside //skb->tci is cleared
> ...
>  --> bond_start_xmit
>    --> bond_xmit_hash //BOND_XMIT_POLICY_ENCAP34
>      --> __skb_flow_dissect // nhoff point to IP header
>         -->  case htons(ETH_P_8021Q)
>              // skb_vlan_tag_present is false, so
>              vlan = __skb_header_pointer(skb, nhoff, sizeof(_vlan),
>              //vlan point to ip header wrongly
> 
> Fixes: b2a103e6d0af ("bonding: convert to ndo_fix_features")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>

Applied and queued up for -stable.