netdev - Re: [PATCH] net: tundra: tsi108: use spin_lock_irqsave instead of spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 08 Aug 2019 22:17:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     huangfq.daxian@...il.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tundra: tsi108: use spin_lock_irqsave instead of
 spin_lock_irq in IRQ context

From: Fuqian Huang <huangfq.daxian@...il.com>
Date: Wed,  7 Aug 2019 15:43:00 +0800

> @@ -372,8 +372,9 @@ static void tsi108_stat_carry(struct net_device *dev)
>  {
>  	struct tsi108_prv_data *data = netdev_priv(dev);
>  	u32 carry1, carry2;
> +	unsigned long flags;

Please preserve reverse christmas tree ordering of local variables.

Thank you.