lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <9f65de8e-bf62-f9b0-5aba-69c0f92df1ca@aquantia.com> Date: Sat, 10 Aug 2019 12:19:36 +0000 From: Igor Russkikh <Igor.Russkikh@...antia.com> To: Antoine Tenart <antoine.tenart@...tlin.com>, "davem@...emloft.net" <davem@...emloft.net>, "sd@...asysnail.net" <sd@...asysnail.net>, "andrew@...n.ch" <andrew@...n.ch>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "hkallweit1@...il.com" <hkallweit1@...il.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>, "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>, "allan.nielsen@...rochip.com" <allan.nielsen@...rochip.com>, "camelia.groza@....com" <camelia.groza@....com>, Simon Edelhaus <Simon.Edelhaus@...antia.com>, Pavel Belous <Pavel.Belous@...antia.com> Subject: Re: [PATCH net-next v2 2/9] net: macsec: move some definitions in a dedicated header Hi Antoine, Overall good looking patchset, great! > +/** > + * struct macsec_tx_sa - transmit secure association > + * @active: > + * @next_pn: packet number to use for the next packet > + * @lock: protects next_pn manipulations > + * @key: key structure > + * @stats: per-SA stats > + */ > +struct macsec_tx_sa { > + struct macsec_key key; > + spinlock_t lock; > + u32 next_pn; > + refcount_t refcnt; > + bool active; > + bool offloaded; I don't see this `offloaded` field being used anywhere. Is this needed? Regards, Igor
Powered by blists - more mailing lists