netdev - Re: [PATCH net] net/tls: swap sk_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190809.195602.1013240319655127797.davem@davemloft.net>
Date:   Fri, 09 Aug 2019 19:56:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com, davejwatson@...com,
        borisp@...lanox.com, aviadye@...lanox.com,
        john.fastabend@...il.com, daniel@...earbox.net,
        oss-drivers@...ronome.com,
        syzbot+dcdc9deefaec44785f32@...kaller.appspotmail.com
Subject: Re: [PATCH net] net/tls: swap sk_write_space on close

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri,  9 Aug 2019 18:36:23 -0700

> Now that we swap the original proto and clear the ULP pointer
> on close we have to make sure no callback will try to access
> the freed state. sk_write_space is not part of sk_prot, remember
> to swap it.
> 
> Reported-by: syzbot+dcdc9deefaec44785f32@...kaller.appspotmail.com
> Fixes: 95fa145479fb ("bpf: sockmap/tls, close can race with map free")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks Jakub.