lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Aug 2019 15:26:17 -0700 (PDT) From: David Miller <davem@...emloft.net> To: gregkh@...uxfoundation.org Cc: netdev@...r.kernel.org Subject: Re: [PATCH v3 00/17] Networking driver debugfs cleanups From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Date: Sat, 10 Aug 2019 12:17:15 +0200 > There is no need to test the result of any debugfs call anymore. The > debugfs core warns the user if something fails, and the return value of > a debugfs call can always be fed back into another debugfs call with no > problems. > > Also, debugfs is for debugging, so if there are problems with debugfs > (i.e. the system is out of memory) the rest of the kernel should not > change behavior, so testing for debugfs calls is pointless and not the > goal of debugfs at all. > > This series cleans up a lot of networking drivers and some wimax code > that was calling debugfs and trying to do something with the return > value that it didn't need to. Removing this logic makes the code > smaller, easier to understand, and use less run-time memory in some > cases, all good things. > > The series is against net-next, and have no dependancies between any of > them if they want to go through any random tree/order. Or, if wanted, > I can take them through my driver-core tree where other debugfs cleanups > are being slowly fed during major merge windows. > > v3: fix build warning in i2400m, I thought I had caught them all :( > add acks from some reviewers > > v2: fix up build warnings, it's as if I never even built these. Ugh, so > sorry for wasting people's time with the v1 series. I need to stop > relying on 0-day as it isn't working well anymore :( Series applied, and fingers crossed, thanks. :)
Powered by blists - more mailing lists