lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 11 Aug 2019 05:39:10 +0200
From:   Andrew Lunn <>
To:     Marek BehĂșn <>
Cc:, Heiner Kallweit <>,
        Sebastian Reichel <>,
        Vivien Didelot <>,
        Florian Fainelli <>,
        "David S . Miller" <>
Subject: Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port

On Sun, Aug 11, 2019 at 05:18:57AM +0200, Marek BehĂșn wrote:
> Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in
> genphy_read_status") broke fixed link DSA port registration in
> dsa_port_fixed_link_register_of: the genphy_read_status does not do what
> it is supposed to and the following adjust_link is given wrong
> parameters.

Hi Marek

Which parameters are incorrect?

In fixed_phy.c, __fixed_phy_register() there is:

        /* propagate the fixed link values to struct phy_device */
        phy->link = status->link;
        if (status->link) {
                phy->speed = status->speed;
                phy->duplex = status->duplex;
                phy->pause = status->pause;
                phy->asym_pause = status->asym_pause;

Are we not initialising something? Or is the initialisation done here
getting reset sometime afterwards?


Powered by blists - more mailing lists