lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Aug 2019 09:32:12 +0200 From: Thomas Bogendoerfer <tbogendoerfer@...e.de> To: Jakub Kicinski <jakub.kicinski@...ronome.com> Cc: Ralf Baechle <ralf@...ux-mips.org>, Paul Burton <paul.burton@...s.com>, James Hogan <jhogan@...nel.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Lee Jones <lee.jones@...aro.org>, "David S. Miller" <davem@...emloft.net>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.com>, Evgeniy Polyakov <zbr@...emap.net>, linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, netdev@...r.kernel.org, linux-rtc@...r.kernel.org, linux-serial@...r.kernel.org Subject: Re: [PATCH v4 7/9] mfd: ioc3: Add driver for SGI IOC3 chip On Fri, 9 Aug 2019 14:22:22 -0700 Jakub Kicinski <jakub.kicinski@...ronome.com> wrote: > On Fri, 9 Aug 2019 12:32:29 +0200, Thomas Bogendoerfer wrote: > > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface. > > It also supports connecting a SuperIO chip for serial and parallel > > interfaces. IOC3 is used inside various SGI systemboards and add-on > > cards with different equipped external interfaces. > > > > Support for ethernet and serial interfaces were implemented inside > > the network driver. This patchset moves out the not network related > > parts to a new MFD driver, which takes care of card detection, > > setup of platform devices and interrupt distribution for the subdevices. > > > > Serial portion: Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > > > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de> > > There are a lot of changes in the ethernet part which are not easy to > explain by the introduction of the other MFD parts.. Could you possibly > break this change up into smaller chunks? working on it > Also please don't use stdint types in the kernel, please try checkpatch > to catch coding style issues. my patch already reduces them and checkpatch only warns about usage of printk for the network part. Changing that to dev_warn/dev_err in the mfd patch didn't seem the right thing to do. As I'm splitting the conversion patch into a few steps I could also replace the printks. Thomas. -- SUSE Linux GmbH GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
Powered by blists - more mailing lists