lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <91cd70df-c856-4c7e-7ebb-c01519fb13d2@gmail.com> Date: Sun, 11 Aug 2019 13:35:20 +0200 From: Heiner Kallweit <hkallweit1@...il.com> To: Marek BehĂșn <marek.behun@....cz> Cc: Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org, Sebastian Reichel <sebastian.reichel@...labora.co.uk>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S . Miller" <davem@...emloft.net> Subject: Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration On 11.08.2019 05:39, Andrew Lunn wrote: > On Sun, Aug 11, 2019 at 05:18:57AM +0200, Marek BehĂșn wrote: >> Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in >> genphy_read_status") broke fixed link DSA port registration in >> dsa_port_fixed_link_register_of: the genphy_read_status does not do what >> it is supposed to and the following adjust_link is given wrong >> parameters. > > Hi Marek > > Which parameters are incorrect? > > In fixed_phy.c, __fixed_phy_register() there is: > > /* propagate the fixed link values to struct phy_device */ > phy->link = status->link; > if (status->link) { > phy->speed = status->speed; > phy->duplex = status->duplex; > phy->pause = status->pause; > phy->asym_pause = status->asym_pause; > } > > Are we not initialising something? Or is the initialisation done here > getting reset sometime afterwards? > In addition to Andrew's question: We talk about this DT config: armada-385-turris-omnia.dts ? Which kernel version are you using? > Thanks > Andrew > Heiner
Powered by blists - more mailing lists