lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Aug 2019 17:08:12 +0200 From: Marek Behún <marek.behun@....cz> To: netdev@...r.kernel.org Cc: Marek Behún <marek.behun@....cz>, Heiner Kallweit <hkallweit1@...il.com>, Sebastian Reichel <sebastian.reichel@...labora.co.uk>, Vivien Didelot <vivien.didelot@...il.com>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, "David S . Miller" <davem@...emloft.net> Subject: [PATCH net-next 2/2] net: fixed_phy: set is_gigabit_capable member when needed The fixed_phy driver does not set the phydev->is_gigabit_capable member when the fixed_phy is gigabit capable. This in turn causes phy_device.c:genphy_read_status function to return unknown phy parameters (SPEED_UNKNOWN, DUPLEX_UNKNOWN, ...), if the fixed_phy is created with SPEED_1000. Signed-off-by: Marek Behún <marek.behun@....cz> Cc: Heiner Kallweit <hkallweit1@...il.com> Cc: Sebastian Reichel <sebastian.reichel@...labora.co.uk> Cc: Vivien Didelot <vivien.didelot@...il.com> Cc: Andrew Lunn <andrew@...n.ch> Cc: Florian Fainelli <f.fainelli@...il.com> Cc: David S. Miller <davem@...emloft.net> --- drivers/net/phy/fixed_phy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 3ffe46df249e..424b02ad7b7b 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -286,6 +286,7 @@ static struct phy_device *__fixed_phy_register(unsigned int irq, phy->supported); linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, phy->supported); + phy->is_gigabit_capable = 1; /* fall through */ case SPEED_100: linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, -- 2.21.0
Powered by blists - more mailing lists