lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Aug 2019 18:08:15 +0200 From: Marek Behun <marek.behun@....cz> To: Andrew Lunn <andrew@...n.ch> Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>, Sebastian Reichel <sebastian.reichel@...labora.co.uk>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S . Miller" <davem@...emloft.net> Subject: Re: [PATCH net-next 2/2] net: fixed_phy: set is_gigabit_capable member when needed On Sun, 11 Aug 2019 17:40:01 +0200 Andrew Lunn <andrew@...n.ch> wrote: > On Sun, Aug 11, 2019 at 05:08:12PM +0200, Marek BehĂșn wrote: > > The fixed_phy driver does not set the phydev->is_gigabit_capable member > > when the fixed_phy is gigabit capable. > > Neither does any other PHY driver. It should be possible to tell if a > PHY supports 1G by looking at register values. If this does not work > for fixed_link, it means we are missing something in the emulation. > That is what we should be fixing. > > Also, this change has nothing to do the lp_advertise, what you > previously said the problem was. At the moment, i don't get the > feeling you have really dug all the way down and really understand the > root causes. > > Andrew Andrew, is_gigabit_capable is otherwise set only in the phy_probe function. This function is not called at all for the DSA cpu port fixed_link phy. Why is that? But I guess it is not important anymore, if CPU and DSA were converted to phylink in net-next. I shall test it and let you know. In any case, sorry for the spam. Marek
Powered by blists - more mailing lists