netdev - Re: [net-next 01/15] ice: Implement ethtool ops for channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a72e5d0ee26743dc5a896a426a55e6e9660f4d2.camel@intel.com>
Date:   Mon, 12 Aug 2019 15:07:09 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>
CC:     "nhorman@...hat.com" <nhorman@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Bowers, AndrewX" <andrewx.bowers@...el.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Tieman, Henry W" <henry.w.tieman@...el.com>
Subject: Re: [net-next 01/15] ice: Implement ethtool ops for channels

On Fri, 2019-08-09 at 14:15 -0700, Jakub Kicinski wrote:
> On Fri,  9 Aug 2019 11:31:25 -0700, Jeff Kirsher wrote:
> > From: Henry Tieman <henry.w.tieman@...el.com>
> > 
> > Add code to query and set the number of queues on the primary
> > VSI for a PF. This is accessed from the 'ethtool -l' and 'ethtool
> > -L'
> > commands, respectively.
> > 
> > Signed-off-by: Henry Tieman <henry.w.tieman@...el.com>
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> > Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> If you're using the same IRQ vector for RX and TX queue the channel
> counts as combined. Looks like you are counting RX and TX separately
> here. That's incorrect.

Hi Jakub,

The ice driver can support asymmetric queues.  We report these
seperately, as opposed to combined, so that the user can specify a
different number of Rx and Tx queues.

Thanks,
Tony

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (3277 bytes)