netdev - Re: [PATCH v3 15/17] i40e: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <016fd56f6128723b6112f1dfe938c9c641e422dc.camel@intel.com>
Date:   Mon, 12 Aug 2019 08:48:53 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH v3 15/17] i40e: no need to check return value of
 debugfs_create functions

On Sat, 2019-08-10 at 12:17 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic
> should
> never do something different based on this.
> 
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

> ---
>  .../net/ethernet/intel/i40e/i40e_debugfs.c    | 22 ++++-------------
> --
>  1 file changed, 4 insertions(+), 18 deletions(-)


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)