netdev - Re: [PATCH] vhost: do not reference a file that does not exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPR809tiAhWqrNz0E5KrFtn-QrMTKv7vQtYq=_mrOH0VWfi0Eg@mail.gmail.com>
Date:   Mon, 12 Aug 2019 13:55:55 -0700
From:   Enrico Granata <egranata@...gle.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Enrico Granata <egranata@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        mst@...hat.com, jasowang@...hat.com, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        trivial@...nel.org
Subject: Re: [PATCH] vhost: do not reference a file that does not exist

Fair enough, yeah.

I think what I found confusing was that the file had a precise
(directly actionable in a file browser, if you will) path. If it was
just listed as a filename, or a project name, it might have been more
obvious that one shouldn't expect to find it within the kernel tree
and just go look it up in your favorite search engine.

The right incantation to get your hands on that file is a web search,
not a local file navigation, and to my perception a full and seemingly
valid path pointed in the direction of doing the wrong thing.

It's not a huge deal, obviously, and it may be that I was the only one
confused by that. If so, feel free to disregard the patch.

Thanks,
- Enrico

Thanks,
- Enrico

On Sat, Aug 10, 2019 at 1:15 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Wed, Aug 07, 2019 at 05:52:55PM -0700, egranata@...omium.org wrote:
> > From: Enrico Granata <egranata@...gle.com>
> >
> > lguest was removed from the mainline kernel in late 2017.
> >
> > Signed-off-by: Enrico Granata <egranata@...gle.com>
>
> But this particular file even has an override in the script looking
> for dead references, which together with the content of the overal
> contents makes me thing the dangling reference is somewhat intentional.