netdev - Re: [PATCH net] netfilter: ebtables: Fix argument order to ADD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190812212545.le2m7vsihcyk7ti6@breakpoint.cc>
Date:   Mon, 12 Aug 2019 23:25:45 +0200
From:   Florian Westphal <fw@...len.de>
To:     Todd Seidelmann <tseidelmann@...ode.com>
Cc:     netdev@...r.kernel.org,
        netfilter-devel <netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH net] netfilter: ebtables: Fix argument order to
 ADD_COUNTER

Todd Seidelmann <tseidelmann@...ode.com> wrote:
> The ordering of arguments to the x_tables ADD_COUNTER macro
> appears to be wrong in ebtables (cf. ip_tables.c, ip6_tables.c,
> and arp_tables.c).
> 
> This causes data corruption in the ebtables userspace tools
> because they get incorrect packet & byte counts from the kernel.

Please send netfilter patches to netfilter-devel@...r.kernel.org .

Fixes: d72133e628803 ("netfilter: ebtables: use ADD_COUNTER macro")

Acked-by: Florian Westphal <fw@...len.de>