lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <232f5c29-748f-1fd3-d9f5-1b13acab46d1@cogentembedded.com> Date: Mon, 12 Aug 2019 12:23:16 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Marek Behún <marek.behun@....cz>, netdev@...r.kernel.org Cc: Heiner Kallweit <hkallweit1@...il.com>, Sebastian Reichel <sebastian.reichel@...labora.co.uk>, Vivien Didelot <vivien.didelot@...il.com>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, "David S . Miller" <davem@...emloft.net> Subject: Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: fix RGMII-ID port setup Hello! On 11.08.2019 18:08, Marek Behún wrote: > The mv88e6xxx_port_setup_mac looks if one of the {link, speed, duplex} > parameters is being changed from the current setting, and if not, does > not do anything. This test is wrong in some situations: this method also > has the mode argument, which can also be changed. > > For example on Turris Omnia, the mode is PHY_INTERFACE_MODE_RGMII_ID, > which has to be set byt the ->port_set_rgmii_delay method. The test does s/byt/by/? > not look if mode is being changed (in fact there is currently no method > to determine port mode as phy_interface_t type). > > The simplest solution seems to be to drop this test altogether and > simply do the setup when requested. > > Signed-off-by: Marek Behún <marek.behun@....cz> > Cc: Heiner Kallweit <hkallweit1@...il.com> > Cc: Sebastian Reichel <sebastian.reichel@...labora.co.uk> > Cc: Vivien Didelot <vivien.didelot@...il.com> > Cc: Andrew Lunn <andrew@...n.ch> > Cc: Florian Fainelli <f.fainelli@...il.com> > Cc: David S. Miller <davem@...emloft.net> [...] MBR, Sergei
Powered by blists - more mailing lists