lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 12 Aug 2019 12:23:16 +0300
From:   Sergei Shtylyov <>
To:     Marek Behún <>,
Cc:     Heiner Kallweit <>,
        Sebastian Reichel <>,
        Vivien Didelot <>,
        Andrew Lunn <>,
        Florian Fainelli <>,
        "David S . Miller" <>
Subject: Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: fix RGMII-ID port setup


On 11.08.2019 18:08, Marek Behún wrote:

> The mv88e6xxx_port_setup_mac looks if one of the {link, speed, duplex}
> parameters is being changed from the current setting, and if not, does
> not do anything. This test is wrong in some situations: this method also
> has the mode argument, which can also be changed.
> For example on Turris Omnia, the mode is PHY_INTERFACE_MODE_RGMII_ID,
> which has to be set byt the ->port_set_rgmii_delay method. The test does


> not look if mode is being changed (in fact there is currently no method
> to determine port mode as phy_interface_t type).
> The simplest solution seems to be to drop this test altogether and
> simply do the setup when requested.
> Signed-off-by: Marek Behún <>
> Cc: Heiner Kallweit <>
> Cc: Sebastian Reichel <>
> Cc: Vivien Didelot <>
> Cc: Andrew Lunn <>
> Cc: Florian Fainelli <>
> Cc: David S. Miller <>

MBR, Sergei

Powered by blists - more mailing lists