lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Aug 2019 17:38:20 +0200 From: Andrew Lunn <andrew@...n.ch> To: Harini Katakam <harinik@...inx.com> Cc: Harini Katakam <harini.katakam@...inx.com>, Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, David Miller <davem@...emloft.net>, Michal Simek <michal.simek@...inx.com>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, radhey.shyam.pandey@...inx.com Subject: Re: [PATCH 2/2] net: gmii2rgmii: Switch priv field in mdio device structure > > The kernel does have a few helper, spi_get_drvdata, pci_get_drvdata, > > hci_get_drvdata. So maybe had add phydev_get_drvdata(struct phy_device > > *phydev)? > > Maybe phydev_mdio_get_drvdata? Because the driver data member available is > phydev->mdio.dev.driver_data. I still prefer phydev_get_drvdata(). It fits with the X_get_drvdata() pattern, where X is the type of parameter passed to the call, spi, pci, hci. We can also add mdiodev_get_drvdata(mdiodev). A few DSA drivers could use that. Andrew
Powered by blists - more mailing lists