netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: check for mode change in port_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190813203234.GO15047@lunn.ch>
Date:   Tue, 13 Aug 2019 22:32:34 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Behún <marek.behun@....cz>
Cc:     netdev@...r.kernel.org, Vivien Didelot <vivien.didelot@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: check for mode change in
 port_setup_mac

On Tue, Aug 13, 2019 at 07:12:43PM +0200, Marek Behún wrote:
> @@ -598,12 +599,49 @@ int mv88e6352_port_link_state(struct mv88e6xxx_chip *chip, int port,
>  			      struct phylink_link_state *state)
>  {
>  	int err;
> -	u16 reg;
> +	u16 reg, mac;
>  
>  	err = mv88e6xxx_port_read(chip, port, MV88E6XXX_PORT_STS, &reg);
>  	if (err)
>  		return err;

Hi Marek

It seems a bit off putting this block of code here, after reading
MV88E6XXX_PORT_STS but before using the value. You don't need STS to
determine the interface mode.

If you keep the code together, you can then reuse reg, rather than add
mac.

Apart from that, this looks O.K.

      Andrew