lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Aug 2019 10:47:13 +0200 From: Philippe Mathieu-Daudé <f4bug@...at.org> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andy Shevchenko <andy.shevchenko@...il.com> Cc: Thomas Bogendoerfer <tbogendoerfer@...e.de>, Ralf Baechle <ralf@...ux-mips.org>, Paul Burton <paul.burton@...s.com>, James Hogan <jhogan@...nel.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Lee Jones <lee.jones@...aro.org>, "David S. Miller" <davem@...emloft.net>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Jiri Slaby <jslaby@...e.com>, Evgeniy Polyakov <zbr@...emap.net>, linux-mips@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-input <linux-input@...r.kernel.org>, netdev <netdev@...r.kernel.org>, "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" <linux-rtc@...r.kernel.org>, "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org> Subject: Re: [PATCH v4 8/9] MIPS: SGI-IP27: fix readb/writeb addressing Hi Thomas, On 8/11/19 9:29 AM, Greg Kroah-Hartman wrote: > On Sat, Aug 10, 2019 at 04:22:23PM +0300, Andy Shevchenko wrote: >> On Fri, Aug 9, 2019 at 1:34 PM Thomas Bogendoerfer >> <tbogendoerfer@...e.de> wrote: >>> >>> Our chosen byte swapping, which is what firmware already uses, is to >>> do readl/writel by normal lw/sw intructions (data invariance). This >>> also means we need to mangle addresses for u8 and u16 accesses. The >>> mangling for 16bit has been done aready, but 8bit one was missing. >>> Correcting this causes different addresses for accesses to the >>> SuperIO and local bus of the IOC3 chip. This is fixed by changing >>> byte order in ioc3 and m48rtc_rtc structs. >> >>> /* serial port register map */ >>> struct ioc3_serialregs { >>> - uint32_t sscr; >>> - uint32_t stpir; >>> - uint32_t stcir; >>> - uint32_t srpir; >>> - uint32_t srcir; >>> - uint32_t srtr; >>> - uint32_t shadow; >>> + u32 sscr; >>> + u32 stpir; >>> + u32 stcir; >>> + u32 srpir; >>> + u32 srcir; >>> + u32 srtr; >>> + u32 shadow; >>> }; >> >> Isn't it a churn? AFAIU kernel documentation the uint32_t is okay to >> use, just be consistent inside one module / driver. >> Am I mistaken? > > No, but really it uint* shouldn't be used anywhere in the kernel source > as it does not make sense. If you respin your series, please send this cleanup as a separate patch. Thanks, Phil.
Powered by blists - more mailing lists