netdev - Re: [PATCH net v2] ibmveth: Convert multicast list size for little-endian system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190813194037.464bea2c@cakuba.netronome.com>
Date:   Tue, 13 Aug 2019 19:43:47 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Thomas Falcon <tlfalcon@...ux.ibm.com>
Cc:     netdev@...r.kernel.org, liuhangbin@...il.com, davem@...emloft.net,
        joe@...ches.com
Subject: Re: [PATCH net v2] ibmveth: Convert multicast list size for
 little-endian system

On Mon, 12 Aug 2019 16:13:06 -0500, Thomas Falcon wrote:
> The ibm,mac-address-filters property defines the maximum number of
> addresses the hypervisor's multicast filter list can support. It is
> encoded as a big-endian integer in the OF device tree, but the virtual
> ethernet driver does not convert it for use by little-endian systems.
> As a result, the driver is not behaving as it should on affected systems
> when a large number of multicast addresses are assigned to the device.
> 
> Reported-by: Hangbin Liu <liuhangbin@...il.com>
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.ibm.com>

Okay, applied, but:

> diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
> index 77af9c2c0571..5641c00d34f2 100644
> --- a/drivers/net/ethernet/ibm/ibmveth.c
> +++ b/drivers/net/ethernet/ibm/ibmveth.c
> @@ -1643,7 +1643,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
>  	struct net_device *netdev;
>  	struct ibmveth_adapter *adapter;
>  	unsigned char *mac_addr_p;
> -	unsigned int *mcastFilterSize_p;
> +	__be32 *mcastFilterSize_p;
>  	long ret;
>  	unsigned long ret_attr;
>  
> @@ -1665,8 +1665,9 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
>  		return -EINVAL;
>  	}
>  
> -	mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev,
> -						VETH_MCAST_FILTER_SIZE, NULL);
> +	mcastFilterSize_p = (__be32 *)vio_get_attribute(dev,
> +							VETH_MCAST_FILTER_SIZE,
> +							NULL);
>  	if (!mcastFilterSize_p) {
>  		dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE "
>  			"attribute\n");
> @@ -1683,7 +1684,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
>  
>  	adapter->vdev = dev;
>  	adapter->netdev = netdev;
> -	adapter->mcastFilterSize = *mcastFilterSize_p;
> +	adapter->mcastFilterSize = be32_to_cpu(*mcastFilterSize_p);
>  	adapter->pool_config = 0;
>  	ibmveth_init_link_settings(adapter);

ibmveth_init_link_settings() is part of your net-next patch which
you're respining, so I had to apply manually. Please double check your
patches apply cleanly to the designated tree.