lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 13 Aug 2019 19:57:55 -0700
From:   Jakub Kicinski <>
To:     Heiner Kallweit <>
Cc:     Andrew Lunn <>,
        Florian Fainelli <>,
        David Miller <>,
        "" <>,
        Yonglong Liu <>
Subject: Re: [PATCH net] net: phy: consider AN_RESTART status when reading
 link status

On Mon, 12 Aug 2019 21:20:02 +0200, Heiner Kallweit wrote:
> After configuring and restarting aneg we immediately try to read the
> link status. On some systems the PHY may not yet have cleared the
> "aneg complete" and "link up" bits, resulting in a false link-up
> signal. See [0] for a report.
> Clause 22 and 45 both require the PHY to keep the AN_RESTART
> bit set until the PHY actually starts auto-negotiation.
> Let's consider this in the generic functions for reading link status.
> The commit marked as fixed is the first one where the patch applies
> cleanly.

Queued for 5.1+, then.

> [0]
> Fixes: c1164bb1a631 ("net: phy: check PMAPMD link status only in genphy_c45_read_link")
> Tested-by: Yonglong Liu <>
> Signed-off-by: Heiner Kallweit <>

Applied, thanks.

Powered by blists - more mailing lists