netdev - RE: [PATCH 3/3] ocelot_ace: fix action of trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Aug 2019 04:28:38 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Andrew Lunn <andrew@...n.ch>,
        "Allan W. Nielsen" <allan.nielsen@...rochip.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH 3/3] ocelot_ace: fix action of trap

Hi Andrew and Allan,

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Tuesday, August 13, 2019 9:43 PM
> To: Y.b. Lu <yangbo.lu@....com>
> Cc: Allan W. Nielsen <allan.nielsen@...rochip.com>; netdev@...r.kernel.org;
> David S . Miller <davem@...emloft.net>; Alexandre Belloni
> <alexandre.belloni@...tlin.com>; Microchip Linux Driver Support
> <UNGLinuxDriver@...rochip.com>
> Subject: Re: [PATCH 3/3] ocelot_ace: fix action of trap
> 
> On Tue, Aug 13, 2019 at 02:12:47AM +0000, Y.b. Lu wrote:
> > Hi Allan,
> >
> > > -----Original Message-----
> > > From: Allan W. Nielsen <allan.nielsen@...rochip.com>
> > > Sent: Monday, August 12, 2019 8:32 PM
> > > To: Y.b. Lu <yangbo.lu@....com>
> > > Cc: netdev@...r.kernel.org; David S . Miller <davem@...emloft.net>;
> > > Alexandre Belloni <alexandre.belloni@...tlin.com>; Microchip Linux
> > > Driver Support <UNGLinuxDriver@...rochip.com>
> > > Subject: Re: [PATCH 3/3] ocelot_ace: fix action of trap
> > >
> > > The 08/12/2019 18:48, Yangbo Lu wrote:
> > > > The trap action should be copying the frame to CPU and dropping it
> > > > for forwarding, but current setting was just copying frame to CPU.
> > >
> > > Are there any actions which do a "copy-to-cpu" and still forward the
> > > frame in HW?
> >
> > [Y.b. Lu] We're using Felix switch whose code hadn't been accepted by
> upstream.
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.ozlabs.org%2Fproject%2Fnetdev%2Flist%2F%3Fseries%3D115399%26s
> tat
> >
> e%3D*&amp;data=02%7C01%7Cyangbo.lu%40nxp.com%7Cfbf7f74803d040f1
> b55608d
> >
> 71ff41b17%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370130
> 05597107
> >
> 485&amp;sdata=xPGDbm2XtDI0L7F5A2xLhDDtctbeqB0MFByCAlgAtJ4%3D&a
> mp;reser
> > ved=0
> >
> > I'd like to trap all IEEE 1588 PTP Ethernet frames to CPU through etype
> 0x88f7.
> 
> Is this the correct way to handle PTP for this switch? For other switches we
> don't need such traps. The switch itself identifies PTP frames and forwards
> them to the CPU so it can process them.
> 
> I'm just wondering if your general approach is wrong?

[Y.b. Lu] PTP messages over Ethernet will use two multicast addresses.
01-80-C2-00-00-0E for peer delay messages.
01-1B-19-00-00-00 for other messages.

But only 01-80-C2-00-00-0E could be handled by hardware filter for BPDU frames (01-80-C2-00-00-0x).
For PTP messages handling, trapping them to CPU through VCAP IS2 is the suggested way by Ocelot/Felix.

I have a question since you are experts.
For other switches, whether they are always trapping PTP messages to CPU?
Is there any common method in linux to configure switch to select trapping or just forwarding PTP messages?

Like Allan's comments in new version patch. I have no idea.
https://patchwork.ozlabs.org/patch/1145988/

Thanks.

> 
>     Andrew