netdev - Re: [PATCH net-next] page_pool: fix logic in __page_pool_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190814142926.3f4b149a@carbon>
Date:   Wed, 14 Aug 2019 14:29:26 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <ilias.apalodimas@...aro.org>, <saeedm@...lanox.com>,
        <ttoukan.linux@...il.com>, <kernel-team@...com>, brouer@...hat.com
Subject: Re: [PATCH net-next] page_pool: fix logic in __page_pool_get_cached

On Tue, 13 Aug 2019 10:45:09 -0700
Jonathan Lemon <jonathan.lemon@...il.com> wrote:

> __page_pool_get_cached() will return NULL when the ring is
> empty, even if there are pages present in the lookaside cache.
> 
> It is also possible to refill the cache, and then return a
> NULL page.
> 
> Restructure the logic so eliminate both cases.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

Thanks for catching and improving this!

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer