netdev - Re: [PATCH net v2] ibmveth: Convert multicast list size for little-endian system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <a496c317-264a-ee1a-238a-4043eb4fcb3e@linux.ibm.com>
Date:   Wed, 14 Aug 2019 10:41:20 -0500
From:   Thomas Falcon <tlfalcon@...ux.ibm.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, liuhangbin@...il.com, davem@...emloft.net,
        joe@...ches.com
Subject: Re: [PATCH net v2] ibmveth: Convert multicast list size for
 little-endian system


On 8/13/19 9:43 PM, Jakub Kicinski wrote:
> On Mon, 12 Aug 2019 16:13:06 -0500, Thomas Falcon wrote:
>> The ibm,mac-address-filters property defines the maximum number of
>> addresses the hypervisor's multicast filter list can support. It is
>> encoded as a big-endian integer in the OF device tree, but the virtual
>> ethernet driver does not convert it for use by little-endian systems.
>> As a result, the driver is not behaving as it should on affected systems
>> when a large number of multicast addresses are assigned to the device.
>>
>> Reported-by: Hangbin Liu <liuhangbin@...il.com>
>> Signed-off-by: Thomas Falcon <tlfalcon@...ux.ibm.com>
> Okay, applied, but:

Thanks!

...

> ibmveth_init_link_settings() is part of your net-next patch which
> you're respining, so I had to apply manually. Please double check your
> patches apply cleanly to the designated tree.

Sorry about that, I thought I fixed that but maybe I got patches mixed 
up somehow.  Thanks again.

Tom