netdev - Re: [PATCH net] sctp: fix the transport error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190813192232.02f49f1f@cakuba.netronome.com>
Date:   Tue, 13 Aug 2019 19:22:32 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>,
        linux-sctp@...r.kernel.org, davem@...emloft.net,
        Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH net] sctp: fix the transport error_count check

On Tue, 13 Aug 2019 13:27:34 -0300, Marcelo Ricardo Leitner wrote:
> On Mon, Aug 12, 2019 at 08:49:12PM +0800, Xin Long wrote:
> > As the annotation says in sctp_do_8_2_transport_strike():
> > 
> >   "If the transport error count is greater than the pf_retrans
> >    threshold, and less than pathmaxrtx ..."
> > 
> > It should be transport->error_count checked with pathmaxrxt,
> > instead of asoc->pf_retrans.
> > 
> > Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg")
> > Signed-off-by: Xin Long <lucien.xin@...il.com>  
> 
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Applied.

> Dave, please consider this one for stable. Thanks.

Ack.