netdev - RE: [net-next 1/1] tipc: clean up skb list lock handling on send path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH2PR15MB3575D75487B422093AEDBE179AAC0@CH2PR15MB3575.namprd15.prod.outlook.com>
Date:   Thu, 15 Aug 2019 13:54:43 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     Xin Long <lxin@...hat.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tung Quang Nguyen <tung.q.nguyen@...tech.com.au>,
        Hoang Huu Le <hoang.h.le@...tech.com.au>,
        "shuali@...hat.com" <shuali@...hat.com>,
        ying xue <ying.xue@...driver.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>
Subject: RE: [net-next  1/1] tipc: clean up skb list lock handling on send
 path



> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> Behalf Of Xin Long
> Sent: 15-Aug-19 01:58
> To: Jon Maloy <jon.maloy@...csson.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; Tung Quang Nguyen
> <tung.q.nguyen@...tech.com.au>; Hoang Huu Le
> <hoang.h.le@...tech.com.au>; shuali@...hat.com; ying xue
> <ying.xue@...driver.com>; edumazet@...gle.com; tipc-
> discussion@...ts.sourceforge.net
> Subject: Re: [net-next 1/1] tipc: clean up skb list lock handling on send path
> 
> 

[...]

> >  	/* Try again later if socket is busy */
> > --
> > 2.1.4
> >
> >
> Patch looks good, can you also check those tmp tx queues in:
> 
>   tipc_group_cong()
>   tipc_group_join()
>   tipc_link_create_dummy_tnl_msg()
>   tipc_link_tnl_prepare()
> 
> which are using skb_queue_head_init() to init?
> 
> Thanks.

You are right. I missed those. I'll post a v2 of this patch.
///jon