netdev - Re: [PATCH v2] selftests: net: tcp_fastopen_backup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190815.113446.175049349135660993.davem@davemloft.net>
Date:   Thu, 15 Aug 2019 11:34:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     anders.roxell@...aro.org
Cc:     shuah@...nel.org, netdev@...r.kernel.org, tim.bird@...y.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests: net: tcp_fastopen_backup_key.sh: fix
 shellcheck issue

From: Anders Roxell <anders.roxell@...aro.org>
Date: Thu, 15 Aug 2019 09:58:26 +0200

> When running tcp_fastopen_backup_key.sh the following issue was seen in
> a busybox environment.
> ./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected
> 
> Shellcheck showed the following issue.
> $ shellcheck tools/testing/selftests/net/tcp_fastopen_backup_key.sh
> 
> In tools/testing/selftests/net/tcp_fastopen_backup_key.sh line 33:
>         if [ $val -ne 0 ]; then
>              ^-- SC2086: Double quote to prevent globbing and word splitting.
> 
> Rework to do a string comparison instead.
> 
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

Applied.