netdev - Re: [PATCH net-next 1/1] fec: add C45 MDIO read/write support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190819.183552.1819321784691078344.davem@davemloft.net>
Date:   Mon, 19 Aug 2019 18:35:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     marco.hartmann@....com
Cc:     fugang.duan@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, christian.herber@....com
Subject: Re: [PATCH net-next 1/1] fec: add C45 MDIO read/write support

From: Marco Hartmann <marco.hartmann@....com>
Date: Mon, 19 Aug 2019 17:11:14 +0000

> @@ -1767,7 +1770,7 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
>  	struct fec_enet_private *fep = bus->priv;
>  	struct device *dev = &fep->pdev->dev;
>  	unsigned long time_left;
> -	int ret = 0;
> +	int ret = 0, frame_start, frame_addr, frame_op;
>  

Please retain the reverse christmas tree ordering of local variables
here, thank you.