netdev - Re: [PATCH 23/38] cls_api: Convert tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190820.165728.2062957580528299761.davem@davemloft.net>
Date:   Tue, 20 Aug 2019 16:57:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     willy@...radead.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 23/38] cls_api: Convert tcf_net to XArray

From: Matthew Wilcox <willy@...radead.org>
Date: Tue, 20 Aug 2019 15:32:44 -0700

> From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> 
> This module doesn't use the allocating functionality; convert it to a
> plain XArray instead of an allocating one.  I've left struct tcf_net
> in place in case more objects are added to it in future, although
> it now only contains an XArray.  We don't need to call xa_destroy()
> if the array is empty, so I've removed the contents of tcf_net_exit()
> -- if it can be called with entries still in place, then it shoud call
> xa_destroy() instead.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>

I don't know if the net exit can be invoked with entires still in place,
however if the tcf_net_exit() function is made empty it should be removed
along with the assignment to the per-netns ops.