netdev - Re: [PATCH net-next 5/6] net: dsa: Allow proper internal use of VLANs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd365947-a057-a915-8e5d-0a3f1b43b5da@gmail.com>
Date:   Mon, 19 Aug 2019 20:20:02 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, vivien.didelot@...il.com,
        andrew@...n.ch, idosch@...sch.org, roopa@...ulusnetworks.com,
        nikolay@...ulusnetworks.com, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 5/6] net: dsa: Allow proper internal use of VLANs



On 8/19/2019 5:00 PM, Vladimir Oltean wrote:
> Below commit:
> 
> commit 2ea7a679ca2abd251c1ec03f20508619707e1749
> Author: Andrew Lunn <andrew@...n.ch>
> Date:   Tue Nov 7 00:04:24 2017 +0100
> 
>     net: dsa: Don't add vlans when vlan filtering is disabled
> 
>     The software bridge can be build with vlan filtering support
>     included. However, by default it is turned off. In its turned off
>     state, it still passes VLANs via switchev, even though they are not to
>     be used. Don't pass these VLANs to the hardware. Only do so when vlan
>     filtering is enabled.
> 
>     This fixes at least one corner case. There are still issues in other
>     corners, such as when vlan_filtering is later enabled.
> 
>     Signed-off-by: Andrew Lunn <andrew@...n.ch>
>     Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> stubs out SWITCHDEV_OBJ_ID_PORT_VLAN objects notified by the bridge core
> to DSA drivers when vlan_filtering is 0.
> 
> This is generally a good thing, because it allows dsa_8021q to make
> private use of VLANs in that mode.
> 
> So it makes sense to move the check for the bridge presence and
> vlan_filtering setting one layer above. We don't want calls from
> dsa_8021q to be prevented by this, only from the bridge core.
> 
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian