[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190820070518.mypyahquun6t4yjf@lx-anielsen.microsemi.net>
Date: Tue, 20 Aug 2019 09:05:20 +0200
From: "Allan W . Nielsen" <allan.nielsen@...rochip.com>
To: Yangbo Lu <yangbo.lu@....com>
CC: <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
"Microchip Linux Driver Support" <UNGLinuxDriver@...rochip.com>,
Andrew Lunn <andrew@...n.ch>
Subject: Re: [v3] ocelot_ace: fix action of trap
Hi,
This is fixing a bug introduced in b596229448dd2
Acked-by: Allan W. Nielsen <allan.nielsen@...rochip.com>
/Allan
The 08/20/2019 12:20, Yangbo Lu wrote:
> External E-Mail
>
>
> The trap action should be copying the frame to CPU and
> dropping it for forwarding, but current setting was just
> copying frame to CPU.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@....com>
> ---
> drivers/net/ethernet/mscc/ocelot_ace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_ace.c
> index 39aca1a..86fc6e6 100644
> --- a/drivers/net/ethernet/mscc/ocelot_ace.c
> +++ b/drivers/net/ethernet/mscc/ocelot_ace.c
> @@ -317,7 +317,7 @@ static void is2_action_set(struct vcap_data *data,
> break;
> case OCELOT_ACL_ACTION_TRAP:
> VCAP_ACT_SET(PORT_MASK, 0x0);
> - VCAP_ACT_SET(MASK_MODE, 0x0);
> + VCAP_ACT_SET(MASK_MODE, 0x1);
> VCAP_ACT_SET(POLICE_ENA, 0x0);
> VCAP_ACT_SET(POLICE_IDX, 0x0);
> VCAP_ACT_SET(CPU_QU_NUM, 0x0);
> --
> 2.7.4
>
>
--
/Allan
Powered by blists - more mailing lists