netdev - Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93fafdab-8fb3-0f2b-8f36-0cf297db3cd9@intel.com>
Date:   Tue, 20 Aug 2019 09:28:26 +0200
From:   Björn Töpel <bjorn.topel@...el.com>
To:     YueHaibing <yuehaibing@...wei.com>, magnus.karlsson@...el.com,
        jonathan.lemon@...il.com, ast@...nel.org, daniel@...earbox.net,
        kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

On 2019-08-20 03:36, YueHaibing wrote:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   kernel/bpf/xskmap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c
> index 4cc28e226398..942c662e2eed 100644
> --- a/kernel/bpf/xskmap.c
> +++ b/kernel/bpf/xskmap.c
> @@ -21,7 +21,7 @@ int xsk_map_inc(struct xsk_map *map)
>   	struct bpf_map *m = &map->map;
>   
>   	m = bpf_map_inc(m, false);
> -	return IS_ERR(m) ? PTR_ERR(m) : 0;
> +	return PTR_ERR_OR_ZERO(m);
>   }
>   
>   void xsk_map_put(struct xsk_map *map)
>

Acked-by: Björn Töpel <bjorn.topel@...el.com>

Thanks for the patch!

For future patches: Prefix AF_XDP socket work with "xsk:" and use "PATCH
bpf-next" to let the developers know what tree you're aiming for.



Cheers!
Björn


> 
>