netdev - RE: [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75471e1fa4de4ac4b5e254827930e0e2@AUSX13MPS302.AMER.DELL.COM>
Date:   Wed, 21 Aug 2019 22:25:58 +0000
From:   <Justin.Lee1@...l.com>
To:     <benwei@...com>, <sam@...dozajonas.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <openbmc@...ts.ozlabs.org>
Subject: RE: [PATCH net-next] net/ncsi: update response packet length for
 GCPS/GNS/GNPTS commands

Hi Ben,

Those are correct adjustment and I had tested previously. 

Thanks,
Justin


Reviewed-by: Justin Lee <justin.lee1@...l.com>


> Update response packet length for the following commands per NC-SI spec
> - Get Controller Packet Statistics
> - Get NC-SI Statistics
> - Get NC-SI Pass-through Statistics command
> 
> Signed-off-by: Ben Wei <benwei@...com>
> ---
>  net/ncsi/ncsi-rsp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 7581bf919885..5254004f2b42 100644
> --- a/net/ncsi/ncsi-rsp.c
> +++ b/net/ncsi/ncsi-rsp.c
> @@ -1083,9 +1083,9 @@ static struct ncsi_rsp_handler {
>  	{ NCSI_PKT_RSP_GVI,    40, ncsi_rsp_handler_gvi     },
>  	{ NCSI_PKT_RSP_GC,     32, ncsi_rsp_handler_gc      },
>  	{ NCSI_PKT_RSP_GP,     -1, ncsi_rsp_handler_gp      },
> -	{ NCSI_PKT_RSP_GCPS,  172, ncsi_rsp_handler_gcps    },
> -	{ NCSI_PKT_RSP_GNS,   172, ncsi_rsp_handler_gns     },
> -	{ NCSI_PKT_RSP_GNPTS, 172, ncsi_rsp_handler_gnpts   },
> +	{ NCSI_PKT_RSP_GCPS,  204, ncsi_rsp_handler_gcps    },
> +	{ NCSI_PKT_RSP_GNS,    32, ncsi_rsp_handler_gns     },
> +	{ NCSI_PKT_RSP_GNPTS,  48, ncsi_rsp_handler_gnpts   },
>  	{ NCSI_PKT_RSP_GPS,     8, ncsi_rsp_handler_gps     },
>  	{ NCSI_PKT_RSP_OEM,    -1, ncsi_rsp_handler_oem     },
>  	{ NCSI_PKT_RSP_PLDM,    0, NULL                     },
> --
> 2.17.1