lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1566361206-5135-1-git-send-email-wenwen@cs.uga.edu> Date: Tue, 20 Aug 2019 23:20:05 -0500 From: Wenwen Wang <wenwen@...uga.edu> To: Wenwen Wang <wenwen@...uga.edu> Cc: "David S. Miller" <davem@...emloft.net>, Richard Fontana <rfontana@...hat.com>, Alexios Zavras <alexios.zavras@...el.com>, Allison Randal <allison@...utok.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thomas Gleixner <tglx@...utronix.de>, netdev@...r.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@...r.kernel.org (open list) Subject: [PATCH v2] net: pch_gbe: Fix memory leaks In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and 'rx_old' are not deallocated, leading to memory leaks. To fix this issue, move the free statements to the outside of the if() statement. Signed-off-by: Wenwen Wang <wenwen@...uga.edu> --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c index 1a3008e..cb43919 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c @@ -340,12 +340,10 @@ static int pch_gbe_set_ringparam(struct net_device *netdev, goto err_setup_tx; pch_gbe_free_rx_resources(adapter, rx_old); pch_gbe_free_tx_resources(adapter, tx_old); - kfree(tx_old); - kfree(rx_old); - adapter->rx_ring = rxdr; - adapter->tx_ring = txdr; err = pch_gbe_up(adapter); } + kfree(tx_old); + kfree(rx_old); return err; err_setup_tx: -- 2.7.4
Powered by blists - more mailing lists