netdev - Re: various TLS bug fixes...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Aug 2019 23:51:12 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: various TLS bug fixes...

On Tue, 20 Aug 2019 22:18:30 -0700, John Fastabend wrote:
> > > I suspect you've triaged through this already on your side for other
> > > reasons, so perhaps you could help come up with a sane set of TLS
> > > bug fix backports that would be appropriate for -stable?  
> > 
> > I'm planning to spend tomorrow working exactly on v4.19 backport. 
> > I have internal reports of openssl failing on v4.19 while v4.20 
> > works fine.. Hopefully I'll be able to figure that one out, test the
> > above and see if there are any other missing fixes.
> > 
> > Is it okay if I come back to this tomorrow?  
> 
> Is the failure with hw offload or sw case? 

SW case, strangely enough. Large file transfer, I think with openssl
client..

> If its sendpage related looks like we also need to push the following
> patch back to 4.19,
>
> commit 648ee6cea7dde4a5cdf817e5d964fd60b22006a4
> Author: John Fastabend <john.fastabend@...il.com>
> Date:   Wed Jun 12 17:23:57 2019 +0000
> 
>     net: tls, correctly account for copied bytes with multiple sk_msgs

I had a quick look at that, but the commit in Fixes is not in v4.19.

> If you have more details I can also spend some cycles looking into it.

Awesome, I'll let you know what the details are as soon as I get them.