netdev - Re: [PATCH net-next 01/10] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190822053357.6309582f@dellmb.labs.office.nic.cz>
Date:   Thu, 22 Aug 2019 05:33:57 +0200
From:   Marek Behún <marek.behun@....cz>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com
Subject: Re: [PATCH net-next 01/10] net: dsa: mv88e6xxx: support 2500base-x
 in SGMII IRQ handler

On Wed, 21 Aug 2019 20:25:42 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Marek Behún <marek.behun@....cz>
> Date: Thu, 22 Aug 2019 01:27:15 +0200
> 
> > int port, int lane) {
> >  	struct dsa_switch *ds = chip->ds;
> > +	u8 cmode = chip->ports[port].cmode;
> >  	int duplex = DUPLEX_UNKNOWN;
> >  	int speed = SPEED_UNKNOWN;
> >  	int link, err;
> > +	phy_interface_t mode;
> >  	u16 status;  
> 
> Please retain the reverse christmas tree ordering of local variables
> here.
> 
> Thank you.

:DDDDDDDDDDDDDDDDDD
Okay, I shall do so in next version.