[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6c2bf55f-e360-c51a-e7bb-effc86aa5b6c@pengutronix.de>
Date: Thu, 22 Aug 2019 17:46:08 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Dan Murphy <dmurphy@...com>, wg@...ndegger.com, davem@...emloft.net
Cc: linux-can@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 3/5] dt-bindings: can: tcan4x5x: Add DT bindings for
TCAN4x5X driver
On 8/22/19 4:20 PM, Dan Murphy wrote:
>>> +tcan4x5x: tcan4x5x@0 {
>>> + compatible = "ti,tcan4x5x";
>>> + reg = <0>;
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + spi-max-frequency = <10000000>;
>>> + bosch,mram-cfg = <0x0 0 0 32 0 0 1 1>;
>>> + data-ready-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
>> Can you convert this into a proper interrupt property? E.g.:
>
> OK. Do you want v13 or do you want patches on top for net-next?
Please use net-next/master as the base.
>>> interrupt-parent = <&gpio4>;
>>> interrupts = <13 0x2>;
>> See:
>> https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/net/can/microchip,mcp251x.txt#L21
>> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/tree/drivers/net/can/spi/mcp251x.c?h=mcp251x#n945
I've removed the branch, as the patches are already upstream, have a
look here:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/tree/drivers/net/can/spi/mcp251x.c#n921
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists