netdev - Re: [PATCH net-next v2] net: openvswitch: Set OvS recirc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190821.205735.2069656948701231785.davem@davemloft.net>
Date:   Wed, 21 Aug 2019 20:57:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     pshelar@....org, netdev@...r.kernel.org, jpettit@...ira.com,
        simon.horman@...ronome.com, marcelo.leitner@...il.com,
        vladbu@...lanox.com, jiri@...lanox.com, roid@...lanox.com,
        yossiku@...lanox.com, ronye@...lanox.com, ozsh@...lanox.com
Subject: Re: [PATCH net-next v2] net: openvswitch: Set OvS recirc_id from
 tc chain index

From: Paul Blakey <paulb@...lanox.com>
Date: Tue, 20 Aug 2019 15:30:51 +0300

> @@ -4050,6 +4060,9 @@ enum skb_ext_id {
>  #ifdef CONFIG_XFRM
>  	SKB_EXT_SEC_PATH,
>  #endif
> +#if IS_ENABLED(CONFIG_NET_TC_SKB_EXT)
> +	TC_SKB_EXT,
> +#endif
>  	SKB_EXT_NUM, /* must be last */
>  };

Sorry, no.

The SKB extensions are not a dumping ground for people to use when they can't
figure out another more reasonable place to put their values.  Try to use
the normal cb[], and if you can't you must explain in exhaustive detail
why you cannot in any way whatsoever make that work.

Again, SKB extensions are not a dumping ground.