netdev - Re: [PATCH] net/ncsi: Fix the payload copying for the request coming from Netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0B7D4454-2976-4E22-AF0D-385616F3B7CF@fb.com>
Date:   Thu, 22 Aug 2019 20:34:22 +0000
From:   Vijay Khemka <vijaykhemka@...com>
To:     "Justin.Lee1@...l.com" <Justin.Lee1@...l.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "sam@...dozajonas.com" <sam@...dozajonas.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH] net/ncsi: Fix the payload copying for the request coming
 from Netlink

LGTM.



On 8/21/19, 2:26 PM, "openbmc on behalf of Justin.Lee1@...l.com" <openbmc-bounces+vijaykhemka=fb.com@...ts.ozlabs.org on behalf of Justin.Lee1@...l.com> wrote:

    The request coming from Netlink should use the OEM generic handler.
    
    The standard command handler expects payload in bytes/words/dwords
    but the actual payload is stored in data if the request is coming from Netlink.
    
    Signed-off-by: Justin Lee <justin.lee1@...l.com>
Reviewed-by: Vijay Khemka <vijaykhemka@...com>
    
    ---
     net/ncsi/ncsi-cmd.c | 11 +++++++++--
     1 file changed, 9 insertions(+), 2 deletions(-)
    
    diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
    index eab4346..0187e65 100644
    --- a/net/ncsi/ncsi-cmd.c
    +++ b/net/ncsi/ncsi-cmd.c
    @@ -309,14 +309,21 @@ static struct ncsi_request *ncsi_alloc_command(struct ncsi_cmd_arg *nca)
     
     int ncsi_xmit_cmd(struct ncsi_cmd_arg *nca)
     {
    +	struct ncsi_cmd_handler *nch = NULL;
     	struct ncsi_request *nr;
    +	unsigned char type;
     	struct ethhdr *eh;
    -	struct ncsi_cmd_handler *nch = NULL;
     	int i, ret;
     
    +	/* Use OEM generic handler for Netlink request */
    +	if (nca->req_flags == NCSI_REQ_FLAG_NETLINK_DRIVEN)
    +		type = NCSI_PKT_CMD_OEM;
    +	else
    +		type = nca->type;
    +
     	/* Search for the handler */
     	for (i = 0; i < ARRAY_SIZE(ncsi_cmd_handlers); i++) {
    -		if (ncsi_cmd_handlers[i].type == nca->type) {
    +		if (ncsi_cmd_handlers[i].type == type) {
     			if (ncsi_cmd_handlers[i].handler)
     				nch = &ncsi_cmd_handlers[i];
     			else
    -- 
    2.9.3