netdev - Re: [PATCH] ethernet: Delete unnecessary checks before the macro call “dev_kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Aug 2019 16:23:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Markus.Elfring@....de
Cc:     netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com,
        intel-wired-lan@...ts.osuosl.org,
        bcm-kernel-feedback-list@...adcom.com,
        UNGLinuxDriver@...rochip.com, alexandre.torgue@...com,
        alexios.zavras@...el.com, allison@...utok.net,
        bryan.whitehead@...rochip.com, claudiu.manoil@....com,
        opendmb@...il.com, dougmill@...ux.ibm.com, f.fainelli@...il.com,
        peppe.cavallaro@...com, gregkh@...uxfoundation.org,
        jeffrey.t.kirsher@...el.com, opensource@...ayne.com,
        jonathan.lemon@...il.com, joabreu@...opsys.com,
        kstewart@...uxfoundation.org, mcgrof@...nel.org,
        mcoquelin.stm32@...il.com, michael.heimpold@...e.com,
        nico@...xnic.net, ynezz@...e.cz, shannon.nelson@...cle.com,
        stefan.wahren@...e.com, swinslow@...il.com, tglx@...utronix.de,
        weiyongjun1@...wei.com, wsa+renesas@...g-engineering.com,
        yang.wei9@....com.cn, yuehaibing@...wei.com, zhongjiang@...wei.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ethernet: Delete unnecessary checks before the macro
 call “dev_kfree_skb”

From: Markus Elfring <Markus.Elfring@....de>
Date: Thu, 22 Aug 2019 20:30:15 +0200

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 22 Aug 2019 20:02:56 +0200
> 
> The dev_kfree_skb() function performs also input parameter validation.
> Thus the test around the shown calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Applied.