netdev - Re: [PATCH net-next 01/10] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190821.202542.800433879227385529.davem@davemloft.net>
Date:   Wed, 21 Aug 2019 20:25:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     marek.behun@....cz
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com
Subject: Re: [PATCH net-next 01/10] net: dsa: mv88e6xxx: support 2500base-x
 in SGMII IRQ handler

From: Marek Behún <marek.behun@....cz>
Date: Thu, 22 Aug 2019 01:27:15 +0200

> diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
> index 20c526c2a9ee..0f3d7cbb696b 100644
> --- a/drivers/net/dsa/mv88e6xxx/serdes.c
> +++ b/drivers/net/dsa/mv88e6xxx/serdes.c
> @@ -506,9 +506,11 @@ static void mv88e6390_serdes_irq_link_sgmii(struct mv88e6xxx_chip *chip,
>  					    int port, int lane)
>  {
>  	struct dsa_switch *ds = chip->ds;
> +	u8 cmode = chip->ports[port].cmode;
>  	int duplex = DUPLEX_UNKNOWN;
>  	int speed = SPEED_UNKNOWN;
>  	int link, err;
> +	phy_interface_t mode;
>  	u16 status;

Please retain the reverse christmas tree ordering of local variables here.

Thank you.